krishan1390 commented on PR #18792: URL: https://github.com/apache/pinot/pull/18792#issuecomment-4732774574
Minor (non-blocking): the concrete `@Override onTableConfigOrSchemaRefresh()` in `BaseTableDataManager` has the same body as the interface `default` (`fetchIndexLoadingConfig()`), so it is technically redundant. Keeping it is defensible as a discoverable extension seam alongside the other `@Override`s, but you could drop it and rely solely on the `default` if you prefer less duplication. Either is fine. Javadoc, wiring, back-compat, and the test all look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
