xiangfu0 commented on code in PR #18784:
URL: https://github.com/apache/pinot/pull/18784#discussion_r3431774943
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -94,6 +94,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
UPSERT_QUERYABLE_DOCS_IN_SNAPSHOT_COUNT("upsertQueryableDocIdsInSnapshot",
false),
REALTIME_INGESTION_OFFSET_LAG("offsetLag", false,
"The difference between latest message offset and the last consumed
message offset."),
+ REALTIME_INGESTION_OOM_PROTECTION_ACTIVE("boolean", false,
+ "Binary indicator (1 or 0) for whether realtime ingestion is currently
blocked by server OOM protection."),
+ REALTIME_INGESTION_OOM_PROTECTION_HEAP_USAGE_PERCENT("percentage", false,
Review Comment:
Done. The ingestion OOM gauges are global now (`setValueOfGlobalGauge`), and
the table-scoped throttle meter was removed so this feature no longer emits
per-table metrics.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -45,6 +45,8 @@ public enum ServerMeter implements AbstractMetrics.Meter {
REALTIME_ROWS_SANITIZED("rows", true),
REALTIME_ROWS_FETCHED("rows", false),
REALTIME_ROWS_FILTERED("rows", false),
+ REALTIME_INGESTION_OOM_PROTECTION_THROTTLED("count", false,
Review Comment:
Done. Removed `REALTIME_INGESTION_OOM_PROTECTION_THROTTLED` and the
per-table meter write; visibility is now only the two global gauges.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -45,6 +45,8 @@ public enum ServerMeter implements AbstractMetrics.Meter {
REALTIME_ROWS_SANITIZED("rows", true),
REALTIME_ROWS_FETCHED("rows", false),
REALTIME_ROWS_FILTERED("rows", false),
+ REALTIME_INGESTION_OOM_PROTECTION_THROTTLED("count", false,
Review Comment:
Done. Removed `REALTIME_INGESTION_OOM_PROTECTION_THROTTLED` and the
per-table meter write; visibility is now only the two global gauges.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -94,6 +94,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
UPSERT_QUERYABLE_DOCS_IN_SNAPSHOT_COUNT("upsertQueryableDocIdsInSnapshot",
false),
REALTIME_INGESTION_OFFSET_LAG("offsetLag", false,
"The difference between latest message offset and the last consumed
message offset."),
+ REALTIME_INGESTION_OOM_PROTECTION_ACTIVE("boolean", false,
+ "Binary indicator (1 or 0) for whether realtime ingestion is currently
blocked by server OOM protection."),
+ REALTIME_INGESTION_OOM_PROTECTION_HEAP_USAGE_PERCENT("percentage", false,
Review Comment:
Done. The ingestion OOM gauges are global now (`setValueOfGlobalGauge`), and
the table-scoped throttle meter was removed so this feature no longer emits
per-table metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
