Copilot commented on code in PR #18796:
URL: https://github.com/apache/pinot/pull/18796#discussion_r3432070630
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerStatelessTest.java:
##########
@@ -1051,6 +1054,40 @@ public void testUpdateTargetTier()
assertTrue(tierToSegmentsMap.isEmpty());
}
+ @Test
+ public void testUpdateTableConfigRefreshesBrokerAndServerCaches()
+ throws Exception {
+ String rawTableName = "tableConfigRefreshTest";
+ String offlineTableName =
TableNameBuilder.OFFLINE.tableNameWithType(rawTableName);
+ addDummySchema(rawTableName);
+ TableConfig tableConfig = new
TableConfigBuilder(TableType.OFFLINE).setTableName(rawTableName)
+ .setBrokerTenant(BROKER_TENANT_NAME)
+ .setServerTenant(SERVER_TENANT_NAME)
+ .build();
Review Comment:
In this test, schema/table creation happens before the try/finally block.
Because this test class reuses the same ZK/Helix cluster across all methods
(@BeforeClass/@AfterClass), an exception during addDummySchema()/addTable()
would skip cleanup and can leak state into subsequent tests. Consider widening
the try/finally to include the schema/table setup so cleanup always runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
