codecov-io edited a comment on issue #4817: Replace ServerInstance with ServerRoutingInstance for Broker scatter-gather URL: https://github.com/apache/incubator-pinot/pull/4817#issuecomment-553204119 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=h1) Report > Merging [#4817](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/895c7eebed77114e962ab5e2dad028cc189e0b8c?src=pr&el=desc) will **increase** coverage by `19.89%`. > The diff coverage is `90%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4817 +/- ## ============================================= + Coverage 37.73% 57.63% +19.89% - Complexity 0 4 +4 ============================================= Files 1213 1212 -1 Lines 65598 65589 -9 Branches 9553 9551 -2 ============================================= + Hits 24753 37799 +13046 + Misses 38580 24936 -13644 - Partials 2265 2854 +589 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/pinot/core/transport/ServerResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyUmVzcG9uc2UuamF2YQ==) | `90.47% <ø> (+9.52%)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/pinot/core/transport/QueryRouter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | `93.22% <100%> (+27.11%)` | `0 <0> (ø)` | :arrow_down: | | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.27% <100%> (+0.07%)` | `0 <0> (ø)` | :arrow_down: | | [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `95.76% <100%> (+30%)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/core/transport/AsyncQueryResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvQXN5bmNRdWVyeVJlc3BvbnNlLmphdmE=) | `96.87% <100%> (+21.87%)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `100% <100%> (+24%)` | `0 <0> (ø)` | :arrow_down: | | [...core/query/selection/SelectionOperatorService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JTZXJ2aWNlLmphdmE=) | `98.11% <100%> (+5.66%)` | `0 <0> (ø)` | :arrow_down: | | [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.8% <100%> (+3.71%)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/pinot/core/transport/ServerChannels.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyQ2hhbm5lbHMuamF2YQ==) | `100% <100%> (+3.12%)` | `0 <0> (ø)` | :arrow_down: | | [...n/java/org/apache/pinot/common/utils/HashUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvSGFzaFV0aWwuamF2YQ==) | `44.06% <50%> (+2.68%)` | `0 <0> (ø)` | :arrow_down: | | ... and [602 more](https://codecov.io/gh/apache/incubator-pinot/pull/4817/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=footer). Last update [895c7ee...8f7d0dc](https://codecov.io/gh/apache/incubator-pinot/pull/4817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
