lazyfetch opened a new pull request, #18818:
URL: https://github.com/apache/pinot/pull/18818
## What changed and why
Closes #18221
`ProtoBufMessageDecoder` has carried a class-level `TODO: Add support for
Schema Registry`
since it was introduced. After reviewing the existing decoder landscape:
- `KafkaConfluentSchemaRegistryProtoBufMessageDecoder` already fully
implements
Confluent Schema Registry-backed descriptor resolution
- `ProtoBufMessageDecoder` is intentionally file-based and
stream-format-agnostic;
adding registry support here would either duplicate that logic or
introduce a
Confluent dependency where there is none today
This PR takes the explicit redirect path listed in the issue scope:
- Replaces the TODO with a comment explaining the design boundary
- Improves the error message when `descriptorFile` is missing to explicitly
point users to `KafkaConfluentSchemaRegistryProtoBufMessageDecoder`
## Testing
Added a test to `ProtoBufMessageDecoderTest` verifying that initialising the
decoder without `descriptorFile` throws an `IllegalStateException` whose
message
references both the missing property name and the registry-backed decoder
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
