timothy-e commented on PR #18658: URL: https://github.com/apache/pinot/pull/18658#issuecomment-4782490282
> Heads-up: found one more user-facing behavioral change in the 1.40 → 1.42 delta that isn't covered in the behavior notes above. > > **[CALCITE-7052](https://issues.apache.org/jira/browse/CALCITE-7052) (1.41) We ran into this issue as well. The original commit even changes a unit test from passing to failing. ```diff @Test void testGroupByAliasEqualToColumnName() { // If the alias (deptno) matches an existing column, it is not used in the GROUP BY sql("select empno, ename as deptno from emp group by empno, deptno") + .withConformance(SqlConformanceEnum.LENIENT) + .throws_("Expression 'ENAME' is not being grouped"); + // If the alias is a new one, it is used in the GROUP BY + sql("select empno, ename as x from emp group by empno, x") .withConformance(SqlConformanceEnum.LENIENT).ok(); } ``` Can we add the `backwards-incompat` to this PR too? It's a little stronger than `needs-attention`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
