yashmayya commented on PR #18179: URL: https://github.com/apache/pinot/pull/18179#issuecomment-4791422676
This bump can't be merged: JavaCC 7.0.13 breaks generation of the Calcite-based SQL parser. CI fails at parser generation in `pinot-common` — JavaCC 7.0.13 emits `SqlParserImpl.java` with uninitialized-variable compile errors: ``` [ERROR] .../sql/parsers/parser/SqlParserImpl.java: error: variable startNum might not have been initialized [ERROR] .../sql/parsers/parser/SqlParserImpl.java: error: variable endNum might not have been initialized [ERROR] .../sql/parsers/parser/SqlParserImpl.java: error: variable reluctant might not have been initialized [INFO] 5 errors ``` This breaks the `pinot-common` build and cascades to every downstream test job (the fast ~2-3 min failures are the compile break, not test failures). It is a genuine incompatibility, not a flaky/unrelated failure. The JavaCC version is deliberately pinned to 5.0 in the root `pom.xml`, with an explicit note: ```xml <!-- Higher version JavaCC throws exception when generating custom Calcite parser --> <version>5.0</version> ``` Closing, since this can't pass while we generate the custom Calcite parser. A follow-up to add an `ignore` rule for `net.java.dev.javacc:javacc` in `.github/dependabot.yml` would stop Dependabot from recreating this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
