Akanksha-kedia commented on PR #17072: URL: https://github.com/apache/pinot/pull/17072#issuecomment-4815883665
@xiangfu0 Fixed the Binary Compatibility Check failure: **Root cause**: `japicmp --exclude @file` matches patterns against fully-qualified **class names** only. The `Class#method` syntax in `japicmp-exclude.xml` is never matched against a class name, so the exclusions were silently ignored and the removed methods were still flagged. **Fix**: Replaced the six `Class#method` entries with two class-level entries: ``` org.apache.pinot.spi.config.table.SegmentsValidationAndRetentionConfig org.apache.pinot.spi.utils.builder.TableConfigBuilder ``` This correctly suppresses the binary incompatibility errors for the intentionally removed deprecated methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
