mayankshriv opened a new pull request #4825: Bug Fix: Fix segment download url in SegmentZkMetadata. URL: https://github.com/apache/incubator-pinot/pull/4825 It turns out that for the case when segment data directory is deep-storage, but the segment upload method is with segment payload being puhsed (as opposed to deep-store URI), the code had a bug where it was generating incorrect download URL in the SegmentZkMetadata. This PR fixes the issue with minimal change, by making the download URL the same as the final location of the segment in deep-store. Having said that, this part of the code seems quite complex with too many variable controls (segment upload type, segment moving or not to final location, etc), it would be good to clean this up at some point.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
