Jackie-Jiang commented on code in PR #18882:
URL: https://github.com/apache/pinot/pull/18882#discussion_r3494630014
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -121,7 +121,6 @@ public void userEventTriggered(ChannelHandlerContext ctx,
Object evt)
protected void channelRead0(ChannelHandlerContext ctx, ByteBuf msg) {
long queryArrivalTimeMs = System.currentTimeMillis();
int requestSize = msg.readableBytes();
- _serverMetrics.addMeteredGlobalValue(ServerMeter.QUERIES, 1);
Review Comment:
Let's keep this for backward compatibility
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -26,7 +26,7 @@
* Enumeration containing all the meters exposed by the Pinot server.
*/
public enum ServerMeter implements AbstractMetrics.Meter {
- QUERIES("queries", true),
+ QUERIES("queries", false),
Review Comment:
We want to keep the global one for backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
