Akanksha-kedia commented on PR #18896:
URL: https://github.com/apache/pinot/pull/18896#issuecomment-4852853446

   cc @Jackie-Jiang @siddharthteotia @npawar — requesting your review.
   
   ## What this PR does
   
   Fixes a UX paper-cut in schema validation: when `SchemaUtils` rejects a 
backward-incompatible schema change, the REST response previously returned a 
generic message like:
   
   > *"Backward incompatible schema myTable. Only allow adding new columns"*
   
   The exception already carries the full reason (which column was removed, 
which type changed, etc.) but it was being silently discarded in the catch 
block. This one-line fix threads `e.getMessage()` into the response:
   
   > *"Backward incompatible schema myTable. Reason: Column 'userId' changed 
type from INT to STRING"*
   
   **Why it matters:** operators debugging failed schema updates had no way to 
know from the API response what was actually wrong — they had to dig into 
controller logs. This surfaces the detail directly in the REST response where 
it belongs.
   
   **Change scope:** one catch block in `PinotSchemaRestletResource`, plus a 
test assertion verifying the message contains the incompatibility detail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to