mayankshriv commented on a change in pull request #4824: Enhance table
rebalance rest API argument check
URL: https://github.com/apache/incubator-pinot/pull/4824#discussion_r346499480
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
##########
@@ -68,8 +68,9 @@
public class TableRebalancer {
private static final Logger LOGGER =
LoggerFactory.getLogger(TableRebalancer.class);
+ // TODO: make them configurable
private static final long EXTERNAL_VIEW_CHECK_INTERVAL_MS = 1_000L; // 1
second
- private static final long EXTERNAL_VIEW_STABILIZATION_MAX_WAIT_MS = 20 *
60_000L; // 20 minutes
+ private static final long EXTERNAL_VIEW_STABILIZATION_MAX_WAIT_MS = 60 *
60_000L; // 1 hour
Review comment:
What's the reasoning behind increasing the wait time from 20 min to 1 hour?
Did we find that 20 minutes might not be good enough? Would be good to document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
