xiangfu0 commented on PR #18915: URL: https://github.com/apache/pinot/pull/18915#issuecomment-4887310167
@dependabot ignore this major version HK2 3.x is not compatible with Pinot's current Jersey 2.x stack as an isolated bump. I reproduced the CI failure locally with: ``` ./mvnw -pl pinot-integration-tests -Dtest=NullHandlingIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test -DskipShade -DskipIntegrationTests=false ``` The first failure is `NoClassDefFoundError: jakarta/annotation/PostConstruct` / `PreDestroy` because HK2 3 expects `jakarta.annotation-api:2.x` while Pinot currently manages `jakarta.annotation-api:1.3.5` for the pre-Jakarta EE API surface. Bumping that annotation API fixes only the first error. The next startup failure is: ``` java.lang.IllegalArgumentException: The implementation class org.glassfish.jersey.inject.hk2.RequestContext must be in the Singleton scope ``` That comes from Jersey 2.48's `jersey-hk2` classes using `javax.inject.Singleton`, while HK2 3 validates against `jakarta.inject.Singleton`. So accepting this major HK2 bump requires a separate Jersey 3 / Jakarta REST migration, not just dependency graph tuning. Until that migration happens, HK2 should stay on 2.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
