Akanksha-kedia commented on PR #18920: URL: https://github.com/apache/pinot/pull/18920#issuecomment-4900297274
Addressed @xiangfu0's review feedback: changed the `storedConfig != null && ...` guard to `properties != null && (storedConfig == null || !storedConfig.equals(currentConfig))` in both `needUpdateIndices` and `updateIndices`. Legacy segments (no persisted jsonIndexConfig) now trigger a one-time rebuild to backfill config and catch any drift. Updated the unit test to assert `true` for the legacy-segment case. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
