Akanksha-kedia commented on PR #18898: URL: https://github.com/apache/pinot/pull/18898#issuecomment-4900299182
Addressed @xiangfu0's review feedback: now comparing both `numHashFunctions` and `numLongs` in `isFppChanged`. Added `NUM_LONGS_OFFSET = 10`, `computeExpectedNumLongs()` (Guava's `ceil(numBits/64)` formula), and extracted `effectiveFpp()` to deduplicate the fpp-capping logic. Rebuild is triggered when either dimension differs. Added `BloomFilterHandlerTest` with a same-k regression test: fpp 0.05→0.045 at cardinality=1000 keeps k=4 but changes numLongs from 98→101, confirming the stale-index case is now caught. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
