xiangfu0 commented on PR #18185: URL: https://github.com/apache/pinot/pull/18185#issuecomment-4910987284
Rebased this PR onto current apache/master (b6c3ca6) and pushed fixes for the review issues. Summary: - Fixed controller metadata aggregation so `includeColumnStats=false` no longer over-fetches or returns `columnCompressionStats`, while preserving the `compressionStats` summary. - Moved the offline compression stats IT into the custom cluster suite and removed the standalone cluster lifecycle. - Tightened the mixed dict/raw server metadata test to generate a real stats-bearing raw segment. - Cleaned up Markdown doc comments/style nits. Validation: - `./mvnw -pl pinot-controller -am -Dtest=TableMetadataReaderCompressionTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl pinot-server -Dtest=TableSizeResourceTest,TablesResourceTest test` - `./mvnw -pl pinot-common -Dtest=ColumnCompressionStatsInfoTest,CompressionStatsSummaryTest,SegmentSizeInfoTest,StorageBreakdownInfoTest,TableMetadataInfoCompressionTest test` - `./mvnw -pl pinot-integration-tests -DskipTests test-compile` - Pre-commit checks on changed modules: `spotless:apply`, `license:format`, `checkstyle:check`, `license:check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
