yashmayya commented on PR #18924: URL: https://github.com/apache/pinot/pull/18924#issuecomment-4917887048
Thanks for the review @gortiz! Addressed all three in 360f3758df: - **Short-circuit for pre-partitioned leaves**: `assignWorkersToLeafFragment` now skips building the routing query entirely when `metadata.isPrePartitioned()`, so colocated-join leaves don't pay the query-construction cost (the `isPrePartitioned` check inside `computePartitionsToKeep` stays as the authoritative guard). - **Partition-level vs segment-level**: added a note to the `computePartitionsToKeep` javadoc (and the PR description) — a surviving partition dispatches all of its segments, including non-matching ones, which the server-side pruners then drop cheaply. This keeps surviving partitions' assignments identical to the unpruned path so the only behavioral delta is dropped workers; segment-level pruning within surviving partitions is a straightforward follow-up (intersect the partition's segment lists with the routed survivors) if the lower pruning ceiling turns out to matter for mixed-match partitions. - **Hybrid coverage**: added `testBrokerPruningPartitionedLeafHybridTable` — offline+realtime TPIs merged through `calculatePartitionTableInfo` with a time boundary, asserting a partition survives via a match on *either* type (`containsAny(offline) || containsAny(realtime)`), the pruned count spans both types, and surviving partitions dispatch both types' full segment lists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
