xiangfu0 commented on code in PR #18932:
URL: https://github.com/apache/pinot/pull/18932#discussion_r3548642354
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ExpressionTransformer.java:
##########
@@ -75,15 +75,16 @@ public ExpressionTransformer(TableConfig tableConfig,
Schema schema) {
if (transformConfigs != null) {
for (TransformConfig transformConfig : transformConfigs) {
FunctionEvaluator previous =
expressionEvaluators.put(transformConfig.getColumnName(),
-
FunctionEvaluatorFactory.getExpressionEvaluator(transformConfig.getTransformFunction()));
+
FunctionEvaluatorFactory.getDeterministicExpressionEvaluator(transformConfig.getTransformFunction()));
Review Comment:
This moves the rejection into the server-side ingestion construction path,
so an existing realtime table that already has a now()/ago()/rand() transform
can fail to build its ExpressionTransformer after an upgrade, before the user
has edited or revalidated the table config. Because those configs were
previously accepted, this needs a backward-compatible rollout path, such as
rejecting only new/updated configs first or preserving runtime compatibility
behind a migration flag/compat shim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
