Jackie-Jiang opened a new pull request, #18956: URL: https://github.com/apache/pinot/pull/18956
## Summary Restructures `TableConfigUtils#validateUpsertAndDedupConfig` to return early when neither upsert nor dedup is enabled, then validate the shared requirements (mutual exclusivity, primary keys, strict replica-group routing, no COMPLETED instance partitions, OFFLINE restrictions) followed by an upsert- or dedup-specific branch. - TTL, MD5-disabled, and partial-upsert validation move into the enabled branch (each only runs for the applicable mode). - The now-redundant `validateAggregateMetricsForUpsertConfig` is removed — the aggregation vs upsert/dedup incompatibility is validated in `validateMetricsAggregation`. - Uses the non-deprecated `TableConfig#isUpsertEnabled()` / `#isDedupEnabled()` helpers instead of `getUpsertMode()`. - Folds in related helper cleanups (`isCommitTimeCompactionEnabled`) and the accompanying test refactor. ## Dependency Stacked on #18955 (the aggregation vs upsert/dedup incompatibility check now lives in `validateMetricsAggregation`, introduced there). Until #18955 merges, this PR's diff includes that commit; please review/merge after #18955. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
