xiangfu0 commented on PR #18953: URL: https://github.com/apache/pinot/pull/18953#issuecomment-4932370171
Two more commits, then CI green on `ed03fea` (13/13). - **`32aa635`** — split the decode-failure diagnostic into a 512-byte text window and a 128-byte hex window. My first cut used one 128-byte cap, which kept binary payloads out of the log but truncated malformed *text* records before the offending field, losing the operator context the old full-payload message gave. Hex costs two characters per byte, so the two caps produce messages of comparable length. - **`ed03fea`** — assert two behaviors that were claimed above but not actually tested. The `assertThrows` on `fromConfig` passed even before the cause was chained, and every `describePayload` fixture was pure ASCII or contained a control byte forcing the hex path, so the "bytes >= 0x80 still render as text" branch was never exercised. Both now have real assertions. Final state: 66 tests in the module, all green; spotless / checkstyle / license clean; all 13 CI checks passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
