Akanksha-kedia opened a new pull request, #18963: URL: https://github.com/apache/pinot/pull/18963
## Summary `IFSTIndexHandler` (case-**I**nsensitive FST) had no unit test coverage. It shares the same index lifecycle pattern as `FSTIndexHandler` but operates on a distinct index type (`StandardIndexes.ifst()`) with its own file extension. Adds `IFSTIndexHandlerTest` with 5 tests: | Test | Scenario | |------|----------| | `testNeedUpdateReturnsTrueWhenColumnRemovedFromConfig` | Column has index but dropped from config → `needUpdateIndices` returns `true` | | `testUpdateIndicesRemovesIndexWhenColumnDroppedFromConfig` | Dropped column → `writer.removeIndex` called | | `testNeedUpdateReturnsTrueWhenNewColumnAdded` | Column in config, no index, metadata present → `true` | | `testNeedUpdateReturnsFalseWhenColumnMetadataAbsent` | Column in config but `getColumnMetadataFor` returns null → `false` | | `testNeedUpdateReturnsFalseWhenIndexUpToDate` | Index present and in config → `false` | ## Test plan - [ ] `IFSTIndexHandlerTest` — 5 unit tests, all green - [ ] `./mvnw checkstyle:check -pl pinot-segment-local` — 0 violations 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
