Copilot commented on code in PR #18972:
URL: https://github.com/apache/pinot/pull/18972#discussion_r3565213198
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java:
##########
@@ -91,6 +94,8 @@ public class JsonExtractScalarTransformFunction extends
BaseTransformFunction {
private TransformFunction _jsonFieldTransformFunction;
private JsonPath _jsonPath;
+ /// Non-null when {@code _jsonPath} is a simple linear chain and the
streaming fast path can resolve it.
+ private SimpleJsonPath _simpleJsonPath;
private DataType _dataType;
Review Comment:
_simpleJsonPath is assigned from SimpleJsonPath.compile(...), which can
return null for non-linear paths, but the field is not annotated as nullable.
This makes nullability unclear and can lead to accidental dereferences later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
