Akanksha-kedia commented on PR #18964: URL: https://github.com/apache/pinot/pull/18964#issuecomment-4951155067
@xiangfu0 @shounakmk219 would appreciate a review when you get a chance. This PR fixes a file-descriptor leak in `HnswVectorIndexCreator`: if `IndexWriter` construction throws after `FSDirectory` is already open, the directory was previously never closed. The fix uses local variables with a try-catch so the directory is always closed on failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
