Jackie-Jiang commented on code in PR #18913:
URL: https://github.com/apache/pinot/pull/18913#discussion_r3572726971
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/LLCSegmentName.java:
##########
@@ -34,7 +34,7 @@ public class LLCSegmentName implements
Comparable<LLCSegmentName> {
private static final DateTimeFormatter DATE_FORMATTER =
DateTimeFormat.forPattern(DATE_FORMAT).withZoneUTC();
private final String _tableName;
- private final int _partitionGroupId;
+ private final TopicPartitionId _topicPartitionId;
Review Comment:
Suggest directly adding `int _topicId` instead of wrapping it in a separate
wrapper. I don't see much value added in this wrapper
The core logic is to parse the segment name with and without topic id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
