Jackie-Jiang commented on code in PR #19012:
URL: https://github.com/apache/pinot/pull/19012#discussion_r3611646162
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/QueryRunnerTest.java:
##########
@@ -333,7 +333,8 @@ protected Iterator<Object[]>
provideTestSqlWithExecutionException() {
new Object[]{"SELECT CAST(jsonExtractScalar(col1, 'path', 'INT') AS
INT) FROM a", "Cannot resolve JSON path"});
// - checked function cannot be found b/c there's no intermediate stage
impl for json_extract_scalar
testCases.add(new Object[]{
- "SELECT CAST(json_extract_scalar(a.col1, b.col2, 'INT') AS INT) FROM a
JOIN b ON a.col1 = b.col1",
+ "SELECT CAST(json_extract_scalar(CONCAT(a.col1, b.col2), 'path',
'INT') AS INT) FROM a JOIN b "
Review Comment:
Why changing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
