Jackie-Jiang commented on code in PR #19038:
URL: https://github.com/apache/pinot/pull/19038#discussion_r3628024510
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/OrFilterOperatorTest.java:
##########
@@ -52,7 +55,7 @@ public void testUnionForTwoLists() {
BlockDocIdIterator iterator =
orOperator.nextBlock().getBlockDocIdSet().iterator();
int docId;
while ((docId = iterator.next()) != Constants.EOF) {
- Assert.assertEquals(docId, expectedIterator.next().intValue());
+ assertEquals(docId, expectedIterator.next().intValue());
}
Review Comment:
Good catch. Added `assertFalse(expectedIterator.hasNext());` after the loop
so a truncated result set (missing trailing docIds) now fails the test.
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/OrFilterOperatorTest.java:
##########
@@ -77,7 +80,7 @@ public void testUnionForThreeLists() {
BlockDocIdIterator iterator =
orOperator.nextBlock().getBlockDocIdSet().iterator();
int docId;
while ((docId = iterator.next()) != Constants.EOF) {
- Assert.assertEquals(docId, expectedIterator.next().intValue());
+ assertEquals(docId, expectedIterator.next().intValue());
}
Review Comment:
Good catch. Added `assertFalse(expectedIterator.hasNext());` after the loop
so a truncated result set (missing trailing docIds) now fails the test.
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/OrFilterOperatorTest.java:
##########
@@ -106,7 +109,7 @@ public void testComplex() {
BlockDocIdIterator iterator =
orOperator.nextBlock().getBlockDocIdSet().iterator();
int docId;
while ((docId = iterator.next()) != Constants.EOF) {
- Assert.assertEquals(docId, expectedIterator.next().intValue());
+ assertEquals(docId, expectedIterator.next().intValue());
}
Review Comment:
Good catch. Added `assertFalse(expectedIterator.hasNext());` after the loop
so a truncated result set (missing trailing docIds) now fails the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
