Jackie-Jiang commented on PR #19054: URL: https://github.com/apache/pinot/pull/19054#issuecomment-5055473710
Updated the approach once more, refining the previous config-flag gate: the recompute decision now uses the `instancePartitionsUnchanged` result computed by the rebalance itself, instead of the `reassignInstances`/`bootstrap` flags. This way a reassignment that turns out to be a no-op also takes the cheap path. The flag can only ratchet from unchanged to changed within the loop (refreshed by the in-loop instance-partition re-calculation): once the instance partitions changed, the base placements keep moving until the rebalance converges, so the full recompute stays required for the rest of the job. PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
