xiangfu0 commented on code in PR #19015:
URL: https://github.com/apache/pinot/pull/19015#discussion_r3636310338
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java:
##########
@@ -147,6 +147,10 @@ public ColumnDataType getFinalResultColumnType() {
@Override
public SerializedTDigest extractFinalResult(TDigest intermediateResult) {
+ if (intermediateResult instanceof PercentileTDigestAccumulator) {
Review Comment:
Rebased onto master now that #19017 is merged. The root-cause fix landed
there (the accumulator overrides `byteSize()`/`asBytes()` to emit `serialize()`
bytes polymorphically), so this call-site change is no longer needed and this
PR no longer touches this file.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileSmartTDigestAggregationFunction.java:
##########
@@ -184,7 +184,7 @@ private void aggregateIntoValueList(int length,
AggregationResultHolder aggregat
}
private TDigest convertValueListToTDigest(DoubleArrayList valueList) {
- TDigest tDigest = TDigest.createMergingDigest(_compression);
+ TDigest tDigest = new PercentileTDigestAccumulator(_compression);
Review Comment:
Same as above — the missing accumulator routing for the Smart function
landed in #19017. After rebasing on top of it, this PR no longer touches this
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
