tarun11Mavani commented on code in PR #19040:
URL: https://github.com/apache/pinot/pull/19040#discussion_r3636784319
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ItemTransformFunction.java:
##########
@@ -58,9 +60,17 @@ public void init(List<TransformFunction> arguments,
Map<String, ColumnContext> c
_keyPath = new String[]{column, key};
DataSource dataSource = columnContextMap.get(column).getDataSource();
- Preconditions.checkState(dataSource instanceof MapDataSource, "Column: %s
must be a MAP column", column);
- MapDataSource mapDataSource = (MapDataSource) dataSource;
- DataSource valueDataSource = mapDataSource.getDataSource(key);
+ Preconditions.checkState(dataSource instanceof MapDataSource || dataSource
instanceof OpenStructDataSource,
+ "Column: %s must be a MAP or OPEN_STRUCT column", column);
+ DataSource valueDataSource;
+ if (dataSource instanceof MapDataSource) {
+ valueDataSource = ((MapDataSource) dataSource).getDataSource(key);
+ } else {
+ valueDataSource = ((OpenStructDataSource) dataSource).getDataSource(key);
Review Comment:
`ImmutableOpenStructDataSource.getDataSource(key)` now returns null for
unmaterialized keys instead of falling back to the sparse JSON column. Callers
handle the null explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
