Jackie-Jiang commented on code in PR #18817:
URL: https://github.com/apache/pinot/pull/18817#discussion_r3651914920
##########
pinot-common/src/thrift/query.thrift:
##########
@@ -32,12 +32,18 @@ struct PinotQuery {
11: optional map<string, string> queryOptions;
12: optional bool explain;
13: optional map<Expression, Expression> expressionOverrideHints;
- // GROUP BY GROUPING SETS / ROLLUP / CUBE: one membership bitmask per
grouping set, over groupByList. Bit i
- // is set iff groupByList[i] participates in (is grouped by) that set; a
mask of 0 is the grand-total set ().
- // Unset for a plain GROUP BY query. Only set when grouping constructs are
used, in which case groupByList (the
- // union of all grouping columns) is capped at 31 entries so a mask always
fits in an i32 (enforced at compile
- // time by CalciteSqlParser.MAX_GROUPING_SETS_COLUMNS); plain GROUP BY
queries have no such limit.
- 14: optional list<i32> groupingSetMasks;
+//14: retired before release (was list<i32> groupingSetMasks, a bitmask
encoding capped at 31 grouping columns);
Review Comment:
Given this is not released, and not used without the new feature, can we
simply remove the old one and reuse the id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
