yashmayya commented on code in PR #19117:
URL: https://github.com/apache/pinot/pull/19117#discussion_r3676921707
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -57,14 +56,23 @@
import static java.nio.charset.StandardCharsets.UTF_8;
-/**
- * The <code>DataSchema</code> class describes the schema of {@link DataTable}.
- */
+/// Describes the schema of a [org.apache.pinot.common.datatable.DataTable].
+///
+/// Instances are effectively immutable and safe to share across threads.
Sharing is common: in the multi-stage engine
Review Comment:
Although this is on column names and not column data types.
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -57,14 +56,23 @@
import static java.nio.charset.StandardCharsets.UTF_8;
-/**
- * The <code>DataSchema</code> class describes the schema of {@link DataTable}.
- */
+/// Describes the schema of a [org.apache.pinot.common.datatable.DataTable].
+///
+/// Instances are effectively immutable and safe to share across threads.
Sharing is common: in the multi-stage engine
Review Comment:
> Instances are effectively immutable
nit - counterexample:
https://github.com/apache/pinot/blob/1aa0e4d06b9028b198aa85c6cdace274dce6a821/pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BaseGapfillProcessor.java#L135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
