adasari commented on code in PR #18334:
URL: https://github.com/apache/pinot/pull/18334#discussion_r3694756175
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java:
##########
@@ -29,8 +29,18 @@
public class DefaultAggregationExecutor implements AggregationExecutor {
protected final AggregationFunction[] _aggregationFunctions;
protected final AggregationResultHolder[] _aggregationResultHolders;
+ protected final Object[] _preAggregatedResults;
- public DefaultAggregationExecutor(AggregationFunction[]
aggregationFunctions) {
+ /**
+ * Creates an executor that skips functions with a pre-aggregated result.
For each index {@code i} where
+ * {@code preAggregatedResults[i]} is non-null, the function is not
aggregated over the scanned blocks and the
+ * pre-aggregated value is emitted directly in the results. A {@code null}
array disables this behavior and all
+ * functions are computed by scanning.
+ *
+ * @param preAggregatedResults per-function pre-aggregated results, or
{@code null} if none are pre-aggregated
+ */
+ public DefaultAggregationExecutor(AggregationFunction[]
aggregationFunctions, Object[] preAggregatedResults) {
Review Comment:
Renamed it to `_nonScanResults`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
