xiangfu0 opened a new pull request, #19141:
URL: https://github.com/apache/pinot/pull/19141
Removes APIs whose deprecations shipped in the 1.1.0 cycle (2023 H2 – early
2024), most of them follow-ups to the high-level-consumer removal. Part of a
series of per-release deprecation sweeps.
All removed members were verified to have zero non-deprecated production
callers. Full-reactor `test-compile`, `checkstyle:check`, and `license:check`
pass.
## Removed
- **`SegmentName`** (whole class — it only delegated to `LLCSegmentName`)
and **`LLCSegmentName.isLowLevelConsumerSegmentName`**, whose only caller was
that class.
- **`TableConfigBuilder.setLLC(boolean)`** — a no-op that only asserted its
own argument was `true`.
- **`SegmentsValidationAndRetentionConfig.getReplicationNumber()` /
`getReplicasPerPartitionNumber()`**. Both were `@JsonIgnore`, so table-config
serialization is unchanged. The other deprecated members of this class are
ZK-serialized and were deliberately left alone.
- **`ZKMetadataProvider`** `ZNRecord`-based `setTableConfig` /
`setRealtimeTableConfig` / `setOfflineTableConfig`. They only referenced each
other; all production paths use the 2-arg `setTableConfig(store, TableConfig)`.
- **`PinotHelixResourceManager.getServersForSegment`** (delegated to
`getServers`).
- **`MinionContext.get/setMinionMetrics`** plus the `_minionMetrics` field.
Verified not load-bearing: `BaseMinionStarter` already calls
`MinionMetrics.register(...)` on the preceding line, and `MinionMetrics.get()`
reads the singleton that `register` sets.
- **Legacy validDocIds read path**:
`ServerSegmentMetadataReader.getValidDocIdsFromServer` and its private URL
helper, plus the server endpoints `GET /segments/{table}/{segment}/validDocIds`
and `GET /tables/{table}/validDocIdMetadata`. Replacements (`GET
.../validDocIdsBitmap`, `POST .../validDocIdsMetadata`) are untouched and have
been in use since 1.2.
- **`SegmentCompletionProtocol.SegmentCommitEndRequest`** and
`MSG_TYPE_COMMIT_END`. Dead since #11662 removed the controller handler for
plain `segmentCommitEnd`; only `segmentCommitEndWithMetadata` remains. Note
these two were never annotated `@Deprecated` — they are dead-code residue
removed alongside their release-line neighbours.
Mixed-version safety was checked against `release-1.5.1`: no component in
the latest release calls any removed endpoint or method.
## backward-incompat
Please apply the **`backward-incompat`** label.
The two removed **server REST endpoints** are the notable part: they were
Swagger-documented and reachable by external tooling (operator scripts,
third-party upsert-compaction drivers), which will now get 404s. Replacements:
- `GET /segments/{table}/{segment}/validDocIds` → `GET
/segments/{table}/{segment}/validDocIdsBitmap`
- `GET /tables/{table}/validDocIdMetadata` → `POST
/tables/{table}/validDocIdsMetadata`
The removed `pinot-spi` methods (`setLLC`, `getReplicationNumber`,
`getReplicasPerPartitionNumber`) are source-breaking for out-of-tree code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
