xiangfu0 commented on issue #19147: URL: https://github.com/apache/pinot/issues/19147#issuecomment-5160488209
#19148 addresses the review comments left on #19139 and #19142 — redundant `FieldConfig` casts, a 404-vs-500 bug on `GET /tables/livebrokers`, and a dead `_minionConf` fallback that would have silently built a plaintext gRPC client. Kept separate so the approved removal PRs aren't churned; it is stacked on #19139 because two of the three fixes don't compile without it. Still deferred and not in any PR yet: the orphaned `ControllerBasedBrokerSelector(scheme, host, port, Properties)` constructor, which #19139 leaves with zero callers. Left out deliberately — it's a public constructor in the published `pinot-java-client` artifact, so removing it is another binary-incompatible change that belongs in the versioned deprecation flow rather than a nit-fix PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
