This is an automated email from the ASF dual-hosted git repository.
xiangfu0 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ae84165bcf3 Remove APIs deprecated in 1.0.0 (#19140)
ae84165bcf3 is described below
commit ae84165bcf3b3f191161a2533cd49e2ba854f167
Author: Xiang Fu <[email protected]>
AuthorDate: Sun Aug 2 15:12:09 2026 -0700
Remove APIs deprecated in 1.0.0 (#19140)
Sunsets deprecated APIs whose deprecations shipped in the 1.0.0 cycle
(2023 H1). All removed members had zero non-deprecated production callers.
- OnHeapGuavaBloomFilterCreator: remove the 4-arg constructor; its own TODO
named #10184 as the exit criteria, which has long since merged
- PinotHelixResourceManager: remove deleteSchema(Schema), which also
returned false on its success path
- PinotHelixResourceManager: remove getSchemaForTableConfig(TableConfig).
Note
this one is NOT a 1.0.0-era deprecation - it was deprecated in 1.4.0 by
#15333 (Mar 2025), when schema became mandatory for all tables. It is
included here rather than held for a 1.4.0 sweep because it has carried
the
annotation through 1.4.0, 1.5.0 and 1.5.1 and has no remaining callers
- PinotSegmentRestletResource: drop the stale "Deprecated APIs" section from
the class javadoc; none of the endpoints it listed still exist
Also repoints SegmentAdminClient.selectSegments from the deprecated
"GET /segments/{tableName}/select" to "GET /segments/{tableName}". The
deprecated endpoint is retained this release so that already-shipped 1.5.x
and 1.6.x clients keep working against an upgraded controller; it can be
deleted once those clients have had a release to migrate.
Two behavior changes follow from the repoint, both of which make the client
match its documented contract:
- selectSegments(..., excludeReplacedSegments=false) now returns replaced
segments. The old endpoint ignored the flag and always excluded them.
- The database header is now honored for segment selection, consistent with
the other /segments endpoints.
---
.../apache/pinot/client/admin/SegmentAdminClient.java | 4 ++--
.../apache/pinot/client/admin/PinotAdminClientTest.java | 2 +-
.../api/resources/PinotSegmentRestletResource.java | 6 ------
.../helix/core/PinotHelixResourceManager.java | 17 -----------------
.../impl/bloom/OnHeapGuavaBloomFilterCreator.java | 8 --------
5 files changed, 3 insertions(+), 34 deletions(-)
diff --git
a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/SegmentAdminClient.java
b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/SegmentAdminClient.java
index a7be6a67943..f59b7a1d953 100644
---
a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/SegmentAdminClient.java
+++
b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/SegmentAdminClient.java
@@ -430,14 +430,14 @@ public class SegmentAdminClient extends
BaseServiceAdminClient {
long endTimestampMs, boolean excludeReplacedSegments)
throws PinotAdminException {
Map<String, String> queryParams = new HashMap<>();
- /// Controller reads startTimestamp/endTimestamp (ms); see
PinotSegmentRestletResource#getSelectedSegments.
+ /// Controller reads startTimestamp/endTimestamp (ms); see
PinotSegmentRestletResource#getSegments.
queryParams.put("startTimestamp", String.valueOf(startTimestampMs));
queryParams.put("endTimestamp", String.valueOf(endTimestampMs));
queryParams.put("excludeReplacedSegments",
String.valueOf(excludeReplacedSegments));
if (tableType != null) {
queryParams.put("type", tableType);
}
- JsonNode response = _transport.executeGet(_controllerAddress, "/segments/"
+ tableName + "/select",
+ JsonNode response = _transport.executeGet(_controllerAddress, "/segments/"
+ tableName,
queryParams, _headers);
return response.toString();
}
diff --git
a/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/admin/PinotAdminClientTest.java
b/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/admin/PinotAdminClientTest.java
index deb6d739397..f44a062a50d 100644
---
a/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/admin/PinotAdminClientTest.java
+++
b/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/admin/PinotAdminClientTest.java
@@ -499,7 +499,7 @@ public class PinotAdminClientTest {
_adminClient.getSegmentClient().selectSegments("tbl1", "OFFLINE", 100L,
200L, true);
- verify(_mockTransport).executeGet(eq(CONTROLLER_ADDRESS),
eq("/segments/tbl1/select"),
+ verify(_mockTransport).executeGet(eq(CONTROLLER_ADDRESS),
eq("/segments/tbl1"),
eq(Map.of("startTimestamp", "100", "endTimestamp", "200",
"excludeReplacedSegments", "true", "type",
"OFFLINE")), eq(HEADERS));
}
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
index 8253b1ab0dd..54945be5228 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
@@ -130,12 +130,6 @@ import static
org.apache.pinot.spi.utils.CommonConstants.SWAGGER_AUTHORIZATION_K
/// - "GET /segments/{tableName}/servers"
/// - Requests with mandatory "type":
/// - "DELETE /segments/{tableName}"
-/// - Deprecated APIs:
-/// - "GET /tables/{tableName}/segments"
-/// - "GET /tables/{tableName}/segments/metadata"
-/// - "GET /tables/{tableName}/segments/crc"
-/// - "GET /tables/{tableName}/segments/{segmentName}"
-/// - "GET /tables/{tableName}/segments/{segmentName}/metadata"
@Api(tags = Constants.SEGMENT_TAG, authorizations = {
@Authorization(value = SWAGGER_AUTHORIZATION_KEY),
@Authorization(value = DATABASE)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
index 69135c8da94..183d944c497 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
@@ -1787,17 +1787,6 @@ public class PinotHelixResourceManager {
LOGGER.info("Updated schema: {}", schemaName);
}
- /// Delete the given schema.
- /// @param schema The schema to be deleted.
- /// @return True on success, false otherwise.
- @Deprecated
- public boolean deleteSchema(Schema schema) {
- if (schema != null) {
- deleteSchema(schema.getSchemaName());
- }
- return false;
- }
-
/// Deletes the given schema. Returns `true` when schema exists, `false`
when schema does not exist.
public boolean deleteSchema(String schemaName) {
LOGGER.info("Deleting schema: {}", schemaName);
@@ -1821,12 +1810,6 @@ public class PinotHelixResourceManager {
return ZKMetadataProvider.getTableSchema(_propertyStore, tableName);
}
- @Deprecated
- @Nullable
- public Schema getSchemaForTableConfig(TableConfig tableConfig) {
- return ZKMetadataProvider.getTableSchema(_propertyStore, tableConfig);
- }
-
/// Get all schema names in the cluster across all databases.
/// @return List of schema names
public List<String> getAllSchemaNames() {
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java
index 30001ca7aba..c26a4e9b32c 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java
@@ -49,14 +49,6 @@ public class OnHeapGuavaBloomFilterCreator implements
BloomFilterCreator {
private final BloomFilter<String> _bloomFilter;
private final FieldSpec.DataType _dataType;
- // TODO: This method is here for compatibility reasons, should be removed in
future PRs
- // exit_criteria: Not needed in Apache Pinot once #10184 is merged
- @Deprecated
- public OnHeapGuavaBloomFilterCreator(File indexDir, String columnName, int
cardinality,
- BloomFilterConfig bloomFilterConfig) {
- this(indexDir, columnName, cardinality, bloomFilterConfig, null);
- }
-
public OnHeapGuavaBloomFilterCreator(File indexDir, String columnName, int
cardinality,
BloomFilterConfig bloomFilterConfig, FieldSpec.DataType dataType) {
_dataType = dataType;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
