Jackie-Jiang commented on code in PR #19148:
URL: https://github.com/apache/pinot/pull/19148#discussion_r3700663340
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/IndexCombinationValidationTest.java:
##########
@@ -513,7 +513,7 @@ public void testRawWithClpCodecNonStringColumnFails() {
public void testDeltaDeltaCodecNonNumericColumnFails() {
// DELTADELTA only valid on INT/LONG columns
FieldConfig fc =
- new FieldConfig(STR_COL, EncodingType.RAW, (List<IndexType>) null,
CompressionCodec.DELTADELTA, null);
+ new FieldConfig(STR_COL, EncodingType.RAW, null,
CompressionCodec.DELTADELTA, null);
Review Comment:
(nit) one line, same for other lines reduced to less than 120
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/IndexCombinationValidationTest.java:
##########
@@ -479,7 +479,7 @@ public void testRawWithSnappyCodecPasses() {
@Test
public void testRawWithZstdCodecPasses() {
FieldConfig fc =
- new FieldConfig(STR_COL, EncodingType.RAW, (List<IndexType>) null,
CompressionCodec.ZSTANDARD, null);
+ new FieldConfig(STR_COL, EncodingType.RAW, null,
CompressionCodec.ZSTANDARD, null);
Review Comment:
(nit) one line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
