swaminathanmanish commented on PR #19094: URL: https://github.com/apache/pinot/pull/19094#issuecomment-5162418393
> @swaminathanmanish Given that we don't have integration tests here, I will be good to verify things locally once and update the findings here. > > * We can edit the buffer time we give for segments state transition to settle say `3 minutes`. > * Add a Thread.sleep() on the state transition path > * Verify that segments are not flagged till 3 minutes but are flagged post that period. > > The verification can be done in some other way as well (preferably using IT's). The above seems to be a decent proxy. I have a test that verifies 1. A recently committed segment (committing state) falls under grace period and we dont alert 2. A committing segment cannot indefinitely be in that state and we alert when that happens The test takes more than 2minutes, to verify these stats and can be flaky, so not adding that now. ControllerPeriodicTasksIntegrationTest is a regression test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
