xiangfu0 commented on code in PR #19118: URL: https://github.com/apache/pinot/pull/19118#discussion_r3715622513
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/virtualcolumn/VirtualColumnProviderFactory.java: ########## Review Comment: Addressed in 5a1fb5cbfe. TableCache now registers `$creationTime` as an SV LONG built-in column, with case-sensitive and case-insensitive coverage in TableCacheTest. The existing `$` wildcard filtering keeps built-in columns out of SELECT *, while explicit `$creationTime` references can be resolved. Validated with TableCacheTest, PinotSegmentRecordReaderTest, RefreshSegmentUpsertMinionTest, and the affected-module quality gates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
