Copilot commented on code in PR #19158:
URL: https://github.com/apache/pinot/pull/19158#discussion_r3717167767
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinStringAggregationFunction.java:
##########
@@ -93,7 +93,7 @@ public void aggregateGroupBySV(int length, int[]
groupKeyArray, GroupByResultHol
String currentMin = groupByResultHolder.getResult(groupKey);
if (currentMin == null || value.compareTo(currentMin) < 0) {
groupByResultHolder.setValueForKey(groupKey, value);
- }
+ }
Review Comment:
Indentation is inconsistent in this lambda: the closing brace for the `if`
block is indented as if it were closing the lambda, which will violate the repo
Checkstyle Indentation rule (basicOffset=2; see config/checkstyle.xml:271-278)
and fail CI.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxStringAggregationFunction.java:
##########
@@ -94,7 +94,7 @@ public void aggregateGroupBySV(int length, int[]
groupKeyArray, GroupByResultHol
String currentMax = groupByResultHolder.getResult(groupKey);
if (currentMax == null || value.compareTo(currentMax) > 0) {
groupByResultHolder.setValueForKey(groupKey, value);
- }
+ }
Review Comment:
Indentation is inconsistent in this lambda: the closing brace for the `if`
block is indented as if it were closing the lambda, which will violate the repo
Checkstyle Indentation rule (basicOffset=2; see config/checkstyle.xml:271-278)
and fail CI.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java:
##########
@@ -301,7 +302,7 @@ protected void aggregateMVGroupByMV(BlockValSet
blockValSet, int length, int[][]
if (_nullHandlingEnabled) {
forEachNotNull(length, blockValSet, (from, to) -> {
- for (int i = from; i < to; i++) {
+ for (int i = from; i < to; i++) {
Double min = null;
for (double value : valuesArray[i]) {
Review Comment:
The `forEachNotNull` lambda body has several lines over-indented (e.g., the
inner `for` and `Double min` lines). This is very likely to fail the Checkstyle
Indentation rule (basicOffset=2; config/checkstyle.xml:271-278).
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxAggregationFunction.java:
##########
@@ -301,7 +302,7 @@ protected void aggregateMVGroupByMV(BlockValSet
blockValSet, int length, int[][]
if (_nullHandlingEnabled) {
forEachNotNull(length, blockValSet, (from, to) -> {
- for (int i = from; i < to; i++) {
+ for (int i = from; i < to; i++) {
Double max = null;
for (double value : valuesArray[i]) {
Review Comment:
The `forEachNotNull` lambda body has several lines over-indented (e.g., the
inner `for` and `Double max` lines). This is very likely to fail the Checkstyle
Indentation rule (basicOffset=2; config/checkstyle.xml:271-278).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
