xiangfu0 commented on code in PR #19165:
URL: https://github.com/apache/pinot/pull/19165#discussion_r3724847803
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java:
##########
@@ -261,6 +262,27 @@ public String[] transformToStringValuesSV(ValueBlock
valueBlock) {
ArrayCopyUtils.copyFromTimestamp(longValues, _stringValuesSV,
length);
return _stringValuesSV;
}
+ case UUID: {
Review Comment:
No production update is needed for the scalar function:
DataTypeConversionFunctions.cast identifies java.util.UUID as
PinotDataType.UUID, and STRING conversion delegates to UUID.toString(), which
is already canonical dashed lowercase. Added direct regression coverage in
39368242d0. Raw byte[] values remain BYTES and intentionally continue to cast
as hex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
