J-HowHuang commented on code in PR #18977:
URL: https://github.com/apache/pinot/pull/18977#discussion_r3724861019
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##########
@@ -359,6 +373,11 @@ Map<String, DefaultColumnAction>
computeDefaultColumnActionMap() {
return defaultColumnActionMap;
}
+ private boolean isTransformFunctionChanged(String column, ColumnMetadata
columnMetadata) {
+ String transformFunctionInMetadata = columnMetadata.getTransformFunction();
+ return !Objects.equals(transformFunctionInMetadata,
getTransformFunctionForColumn(column));
Review Comment:
For legacy segments with derived columns, they'll come with `null` transform
function from metadata and guaranteed a segment rebuild? Is it better to have a
no-op for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
