xiangfu0 commented on PR #19182: URL: https://github.com/apache/pinot/pull/19182#issuecomment-5223007391
Addressed the remaining review question about what is inserted into the Bloom filter: - UUID ingestion normalizes values to the 16-byte stored representation. - `BloomFilterCreator` dispatches on `getStoredType()`; UUID therefore follows the `BYTES` path. - The Bloom key is `BytesUtils.toHexString(byte[])`, i.e. lowercase dashless hex. - Query literals (dashless hex or `CAST(canonical AS UUID)`) normalize to the same bytes/hex key. The new `UuidBloomFilterTest` validates both query forms through a real cluster and asserts that present segments are processed while an absent in-range UUID is Bloom-pruned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
