goutamadwant commented on PR #19178: URL: https://github.com/apache/pinot/pull/19178#issuecomment-5234259670
Thanks @Jackie-Jiang. I updated the PR to follow the suggested mechanism: - After clearing shutDownInProgress, the server reads the online brokers from the brokerResource external view. - It asks each broker whether the server is currently routable. - The broker check is synchronized with routing updates, so it cannot return success while the instance-config callback is still being applied. - Server readiness remains false until every online broker confirms. Broker membership is revalidated before caching the ready state. The checks run concurrently and stop after readiness is established. I also added unit tests and an HTTP integration test covering the 200 and 503 responses. Let me know if you have any comments. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
