Akanksha-kedia commented on PR #19046: URL: https://github.com/apache/pinot/pull/19046#issuecomment-5236295662
Hi @J-HowHuang — noting the consistency concern raised in apache/pinot#18920 here as well, since this PR is one of the three cited. The vector index currently persists its config as an individual metadata file. To address the uniform-solution request, `loadMetadataProperties()`, `readStoredIndexConfig()`, and `setStoredIndexConfig()` have been added to `BaseIndexHandler` (landed in apache/pinot#18920) as protected generic utilities backed by the existing `metadata.properties` file. Any handler can now call them with a stable key suffix (e.g. `"vectorIndexConfig"`) to persist and compare any `IndexConfig` subclass without duplicating the serialization boilerplate. Happy to migrate this PR to use that pattern in a follow-up if you'd prefer a consistent approach across all three PRs. Alternatively, if the individual-file approach is preferred here (e.g. for size or isolation reasons), let me know and we can document the rationale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
