swaminathanmanish commented on PR #19161: URL: https://github.com/apache/pinot/pull/19161#issuecomment-5240147211
> Can we add following integration tests if easily possible. > > 1. Perform the transaction and see if anything is actually reported or not. > 2. Delete the offsets and check if the flag has been set to true/ false or a metric is emitted. Good callout. Added the tests and removed mocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
