Vamsi-klu commented on PR #19026: URL: https://github.com/apache/pinot/pull/19026#issuecomment-5249496703
Pushed `d9f0282`. Both failures were one spotless import-order violation in `TestConfigEngine.java`, where the `MemoryEstimator` import sat out of alphabetical order. Linter and Quickstart run the same check, so the single fix clears both. Rebased onto latest master, which also surfaced a few `/** */` doc blocks in the files this PR adds, so those are converted to `///` in the same push. Two things worth a deliberate look while reviewing: over-host-memory cells now show real estimates instead of NA, so NA means only that the hours exceed retention, and warnings are exposed as a numbered map under the existing recommender payload shape rather than the array shape mentioned in #8339, to stay JSON backward compatible. Happy to change either based on your preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
