Vamsi-klu commented on PR #19088: URL: https://github.com/apache/pinot/pull/19088#issuecomment-5249499643
Pushed `4a0dfe3` with both actionable threads addressed, details on each. I checked the new tests by reverting only the `MutableSegmentImpl` hunks and re-running: 3 of the 5 tests in `IndexingFailureTest` fail without the fix and all 5 pass with it, so they genuinely pin the behavior rather than just passing. The other mutable-segment suites are green locally as well, 29 tests. One deliberate deferral worth stating rather than leaving silent: `addPhysicalColumn` still iterates `indexContainer._mutableIndexes` in HashMap order instead of writing the forward index first. It is a separate concern from the two threads here and none of the new tests depend on ordering, so I would rather do it as a follow-up than widen this PR. Happy to fold it in if a reviewer prefers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
