Vamsi-klu commented on PR #18976:
URL: https://github.com/apache/pinot/pull/18976#issuecomment-5249500598
Pushed `7388fdf`. The Unit Test Set 2 failure was real and caused by this
change: `JSONRecordReader` now returns `BigDecimal("3.0")` for floating JSON
literals, where `PinotSegmentConverterTest.testJsonConverter` asserted a
`Double`. That is why the message read "expected [3.0] but found [3.0]", same
string, different type.
The float and double assertions compare numerically now, element-wise for
the multi-value cases, which documents the new type-agnostic contract rather
than hiding the behavior change. INT and LONG assertions are untouched since
integral literals are unaffected. Rebased onto latest master, and the reader,
extractor and JsonUtils suites are green locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
