shauryachats commented on code in PR #19064:
URL: https://github.com/apache/pinot/pull/19064#discussion_r3770271051
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryResponse.java:
##########
@@ -70,7 +70,11 @@ Map<ServerRoutingInstance, ServerResponse>
getFinalResponses()
long getServerResponseDelayMs(ServerRoutingInstance serverRoutingInstance);
/**
- * Returns the failed server if the query fails.
+ * Returns the server that went down during the query. Set when the query
fails, and also when the query returns
+ * partial results under {@code skipUnavailableServers} (used by the failure
detector to quarantine the server from
+ * routing). Because it can be set on a partial success, a non-null value
does not by itself imply the query
+ * failed; check {@link #getException()} / {@link #getStatus()} for that. At
most one server is tracked per query -
+ * when several servers go down, this holds the most recent one.
*/
@Nullable
ServerRoutingInstance getFailedServer();
Review Comment:
Can you verify that all callers of this method work with the changed
contract above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
