xiangfu0 opened a new pull request, #19231: URL: https://github.com/apache/pinot/pull/19231
## Summary - Establish and canonicalize the final segment destination before controller storage or metadata handling. - Authorize the exact destination table for every v1 upload variant and reject inconsistent request, header, or segment metadata table names. - Preserve v2 request-table promotion behavior while binding database headers and batch uploads to their authorized destinations. - Return clear client errors for missing, blank, invalid, or mismatched table inputs. ## Root cause The upload handlers did not share a canonical destination-binding step across request inputs and segment metadata. In v1, authorization could therefore complete before the final table destination was established. ## Impact Upload and refresh authorization now targets the same table used by all subsequent controller operations, independently of the configured access-control implementation. Existing valid v2 promotion behavior remains supported. ## How to reproduce Run the added `PinotSegmentUploadAuthorizationTest`. It configures permissive cluster-level create access with table-scoped authorization and exercises v1, v2, batch, upload, and refresh destination handling. ## Validation - `FineGrainedAuthUtilsTest` - `PinotSegmentUploadDownloadRestletResourceTest` - `PinotSegmentUploadAuthorizationTest` - Spotless, Checkstyle, and license checks for `pinot-core` and `pinot-controller` - JDK 25 warning-enabled test compilation for both affected modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
